Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded suma tree url #1269

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

lcaparroz
Copy link
Member

@lcaparroz lcaparroz commented Jan 3, 2025

Description

Fix bug that hardcoded the SUMA product tree URL to 'scc.suse.com' even if a different host was specified in the RMT configuration file.

How to test

  1. Edit config/rmt.local.yml and change scc.host to point to a different host than https://scc.suse.com/connect, e.g.: http://localhost:3000/connect

  2. On the project root directory, run bin/rmt-cli mirror --debug. If the command succeeds in downloading the SUMA product tree, it should print a similar output:

    I, [2025-01-03T12:19:11.738742 #1623]  INFO -- : Mirroring SUSE Manager product tree to <...>/rmt/public/suma/
    D, [2025-01-03T12:19:11.741255 #1623] DEBUG -- : HTTP request for: http://localhost:3000/suma/product_tree.json
    I, [2025-01-03T12:19:13.112999 #1623]  INFO -- : ↓ product_tree.json
    D, [2025-01-03T12:19:13.113127 #1623] DEBUG -- :   (new mtime: 2025-01-03 11:19:13 UTC)
    
  3. Verify that the output shows the SUMA product tree is downloaded from the same host as specified in the RMT configuraion file.

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

Fix bug that hardcoded the SUMA product tree URL to 'scc.suse.com' even
if a different host was specified in the RMT configuration file.
(bsc#1234844)
@lcaparroz lcaparroz requested a review from digitaltom January 3, 2025 11:42
@digitaltom digitaltom added the 2.21 label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants