Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with newer Python interpreter #151

Closed
wants to merge 1 commit into from
Closed

Build with newer Python interpreter #151

wants to merge 1 commit into from

Conversation

rjschwei
Copy link
Contributor

@rjschwei rjschwei commented Jun 7, 2024

The code requires capture_output as an argument to subprocess which was introduced in Python 3.7, thus we can no longer builds against Python 3.6 default on SLE 15 and openSUSE Leap 15 and have to build against a newer version of Python available with 15.4 and later.

The code requires capture_output as an argument to subprocess which was
introduced in Python 3.7, thus we can no longer builds against Python 3.6
default on SLE 15 and openSUSE Leap 15 and have to build against a newer
version of Python available with 15.4 and later.
@rjschwei rjschwei requested a review from jgleissner June 7, 2024 19:25
%if %python_version_nodots < 37
Requires: python-iso8601
%endif
Requires: python311-kiwi >= 9.21.21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently no package python311-kiwi, except for in Virtualization:Appliances:Builder (in OBS) and just for Leap build targets. The spec file is the same in openSUSE:Factory but it specifically builds a python 3.11 package in Leap/SLE 15 but in Tumbleweed/ALP it still builds python3-kiwi. IMO the kiwi spec file should be updated to build for multiple python versions like other packages and then the Requires can be changed to python-kiwi.

@@ -67,7 +62,7 @@ KEG is an image composition tool for KIWI image descriptions
Summary: An OBS service: generate KIWI description using KEG
Group: Development/Tools/Building
Requires: git
Requires: python3-kiwi-keg = %version
Requires: python311-kiwi-keg = %version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change forces a user of obs-service-compose_kiwi_description to use the 3.11 version. That is currently the case anyway due to kiwi only being available for the main python version, but ideally the user should be able to choose which version to use. And we shouldn't require a specific python version IMO as it will break when python version changes.

@rjschwei
Copy link
Contributor Author

rjschwei commented Jul 3, 2024

Superseded by #152

@rjschwei rjschwei closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants