Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme with details about archive #147

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Update readme with details about archive #147

merged 2 commits into from
Jan 12, 2024

Conversation

smarlowucf
Copy link
Collaborator

And clean up option description for archive values in example config.

@smarlowucf
Update readme with details about archive
63673d5 
And clean up option description for archive values in example
config.
KeithMnemonic
KeithMnemonic approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@KeithMnemonic KeithMnemonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rtamalin
rtamalin reviewed Jan 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
rtamalin
rtamalin reviewed Jan 11, 2024
View reviewed changes
examples/README.md Outdated Show resolved Hide resolved
rtamalin
rtamalin requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@rtamalin rtamalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Made one suggestion for better visual conveyance of multiple elements in the usage_records list, and one typo correction.

@smarlowucf smarlowucf requested a review from rtamalin January 11, 2024 21:26
KeithMnemonic
KeithMnemonic approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@KeithMnemonic KeithMnemonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rtamalin
rtamalin approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@rtamalin rtamalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarlowucf smarlowucf merged commit 26fa272 into data-archive Jan 12, 2024
6 checks passed
@smarlowucf smarlowucf deleted the arch-docs branch January 12, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtamalin rtamalin rtamalin approved these changes

@KeithMnemonic KeithMnemonic KeithMnemonic approved these changes

@rjschwei rjschwei rjschwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smarlowucf @rjschwei @KeithMnemonic @rtamalin