Add archive bytes limit option to config #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the max length of the archive in bytes. If the archive grows larger than this limit the archive is trimmed until it satisfies the limit. For k8s products this limit is 1MiB or 1048576 bytes. If the limit is set to 0 there is no size limit. The archive can grow as large as the retention period.
rjschwei
reviewed
Jan 10, 2024
rjschwei
requested changes
Jan 10, 2024
rjschwei
approved these changes
Jan 10, 2024
Drop defaults as these are not functional. The way the config is written a value must be provided in config. - Treat a 0 or 1 in bytes limit as "disable archive" - Treat < 1 in retention period as "disable archive" - Treat < 0 in bytes limit as no limit
|
Made changes per comments:
Changed how the values are treated to the following:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the max length of the archive in bytes. If the archive grows larger than this limit the archive is trimmed until it satisfies the limit.
For k8s products this limit is 1MiB or 1048576 bytes. If the limit is set to -1 there is no size limit. The archive can grow as large as the retention period. If the limit is set to 0 the archive feature is disabled.