Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full docstring to function #143

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Add full docstring to function #143

merged 2 commits into from
Jan 9, 2024

Conversation

smarlowucf
Copy link
Collaborator

No description provided.

KeithMnemonic
KeithMnemonic approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@KeithMnemonic KeithMnemonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brett060102
brett060102 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@brett060102 brett060102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@smarlowucf
Include comment about max length handling
a2f4c85 
In the return section of docstring.
@smarlowucf smarlowucf merged commit f342b84 into data-archive Jan 9, 2024
6 checks passed
@smarlowucf smarlowucf deleted the append-record-doc branch January 9, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtamalin rtamalin rtamalin left review comments

@brett060102 brett060102 brett060102 approved these changes

@KeithMnemonic KeithMnemonic KeithMnemonic approved these changes

@rjschwei rjschwei rjschwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smarlowucf @rjschwei @KeithMnemonic @rtamalin @brett060102