Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qa-scenario-2a (SOC-10460) #3711

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

gosipyan
Copy link
Contributor

Deploy cluster on 3 node
Use mysql for database
Add scenario with CA certs

@gosipyan gosipyan changed the title Update qa-scenario-8a Update qa-scenario-2a Sep 23, 2019
wkogithub
wkogithub previously approved these changes Sep 23, 2019
Copy link
Contributor

@wkogithub wkogithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -222,19 +208,6 @@ proposals:
heat-server:
- cluster:services

- barclamp: ceilometer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing Ceilometer from the scenario?

Copy link
Contributor Author

@gosipyan gosipyan Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

during prechecks if monasca is missing upgrade wont go further unless i remove ceilometer and as such case already covered in qa-scenario-8a(deploying monasca) I decided remove it from here ,other option would be deploy monasca , but because not enough nodes avaible i think it would be complicated .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok. I was wondering about that because I created dedicated precheck clean scenarios in #3682 which is a little...starved for reviews... :-)

What do we do about this? Merge the dedicated scenarios or remove all precheck breakers from the existing ones (in that case there'd be more things to change). I for one would prefer having dedicated upgrade scenarios in order to continue testing the barclamps that are still supported on Cloud 8 for Cloud 8 rather than disabling them for regular Cloud 8 (i.e. in non-upgrade situations) as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted do two things together fix broken scenario in general for SOC8 and make them working for upgrade so we dont need duplicate
I expect those scenarios under cloud8 run only for upgrade porpuse I dont think we would use them for anything else .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Then I'll +1 this for now, since I have none of the non-precheck fixes in my pull request. We may need a follow-up to take care of Aodh, Trove and more Ceilometer occurences as well though (unless someone has taken care of that in the time since I created #3682 ; haven't checked).

jgrassler
jgrassler previously approved these changes Sep 23, 2019
Deploy cluster on 3 node
Use mysql for database
Add scenario with CA certs
@gosipyan gosipyan changed the title Update qa-scenario-2a Update qa-scenario-2a (SOC-10460) Nov 28, 2019
Copy link
Contributor

@jgrassler jgrassler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it, but it looks good to me (and fixes a whole bunch of stuff; we can always do the rest in a followup, especially for QA scenarios).

@gosipyan
Copy link
Contributor Author

hawk-server:
- "@@data1@@"
- "@@data2@@"

- barclamp: pacemaker
name: network
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we loose a dedicated network cluster?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have only enough nodes for 2 clusters(with 3 nodes) I can remove data and add network back if you think its better coverage /scenario

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Lets leave it like this if there are no more nodes available.

Copy link
Member

@skazi0 skazi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gosipyan gosipyan merged commit 169715b into SUSE-Cloud:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants