Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Octo-Tiger segfaults when using HPX master #477

Closed
wants to merge 1 commit into from

Conversation

G-071
Copy link
Member

@G-071 G-071 commented Jan 13, 2024

Using HPX master uncovered an issue within Octo-Tiger causing segfaults during the initialization (as outlined in the original HPX issue STEllAR-GROUP/hpx#6414 and the PR STEllAR-GROUP/hpx#6415)

This should hotfix the issue for now (at least the local tests pass again)!
However, in the future we will want to remove this part of the code and use shared_ptr instead via

future<std::shared_ptr<node_server>> node_client::get_ptr() const {
    return hpx::get_ptr<node_server>(get_unmanaged_gid());
}

to properly fix this.

@G-071
Copy link
Member Author

G-071 commented Jan 14, 2024

Closed due to #479 providing a better fix!

@G-071 G-071 closed this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant