Fix Octo-Tiger segfaults when using HPX master #477
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using HPX master uncovered an issue within Octo-Tiger causing segfaults during the initialization (as outlined in the original HPX issue STEllAR-GROUP/hpx#6414 and the PR STEllAR-GROUP/hpx#6415)
This should hotfix the issue for now (at least the local tests pass again)!
However, in the future we will want to remove this part of the code and use shared_ptr instead via
to properly fix this.