Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lci pp): fix the null_thread_id bug in the LCI parcelport #6401

Closed
wants to merge 1 commit into from

Conversation

JiakunYan
Copy link
Contributor

send() in the LCI parcelport can call HPX yield(). However, send() can be called outside HPX threads, leading to HPX complaining "null_thread_id".

@JiakunYan JiakunYan requested a review from hkaiser as a code owner December 18, 2023 17:58
`send()` in the LCI parcelport can call HPX `yield()`. However,
`send()` can be called outside HPX threads, leading to HPX complaining
"null_thread_id".
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.15% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8b438bf) 397874 336695 84.62%
Head commit (c30e9b1) 195086 (-202788) 164798 (-171897) 84.47% (-0.15%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6401) 2 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@JiakunYan
Copy link
Contributor Author

Changes are overwritten by #6402

@hkaiser hkaiser added this to the 1.10.0 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants