Fx the affinity setting bug when using LCI pp and multiple localities per node #6400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6398.
The HPX runtime relies on
used_cores_map_
to set the affinity correctly when running multiple localities per node (seeruntime_distributed::assign_cores
for details).used_cores_map_
maps hostnames to "used cores" and assumes the hostname of all localities on the same node are the same. The hostname is generated using theparcelport::get_locality_name
method (I would say the name of this method is misleading).The previous LCI parcelport used "processor_name+rank" as a locality name, which breaks the assumption of
used_cores_map_
. This PR fixed this issue.