Add inlining of #whileTrue:/#whileFalse: #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add new bytecodes - add basic check of consistency of bytecode definitions - field access bytecodes don’t use context argument, which is different from other SOMs Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
|
Median reducing in runtime of 21% https://rebench.dev/SOMpp/compare/f3758d78ec2d55fb11bbd6add8fe488247d33fda..0e79876fdfefe909bb28d6f3d926080cf0f97eeb 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the infrastructure introduced previously in #32 to implement bytecode-level inlining in the same style as in TruffleSOM and PySOM.
One improvement here is that we remove blocks from the literals, too, which leads in the tests to use more use of the specialized bytecodes.
Generally, the new introduced bytecodes for jumps have all the same length, and exist in two variants, one that only uses one byte, i.e., shorted jumps, and the other that uses both.
This also introduces keeping track of the last 4 bytecodes, which is useful for other optimizations later on, too.