Work on GC issues #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sanitizers just make these run for too long. Signed-off-by: Stefan Marr <[email protected]>
- IsValidObject should be used in debug mode - reorder tests, null check first - add messages to asserts - handle forwarded objects - add assertions to AddLiteral, and use it for IfAbsent Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]> Define log levels to be able to be more selective with debug logging Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
But delay write barrier to the subclass constructors to make sure the object is already constructed. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
The hash is expected to be stable, for instance, to use it in a hash table. Signed-off-by: Stefan Marr <[email protected]>
- fix include order - add missing parentheses - type int literals - use static instead of instance way of calling static method - avoid ambiguous signature Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
…e CopyingHeap Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
- as part of this do a bit of refactoring, defining a funtion to get and check the vtable of an oop Signed-off-by: Stefan Marr <[email protected]>
- check more consistently for no superclass Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
… not of strings Signed-off-by: Stefan Marr <[email protected]>
I’d expect this to be a primitive, but just to be sure… Signed-off-by: Stefan Marr <[email protected]>
This GC uses malloc to allocate objects, but otherwise behaves like a semi-space GC. This hopefully enables us to use memory/address senatizers to catch GC bugs. Signed-off-by: Stefan Marr <[email protected]>
This makes it a bit more complicated to work out the totalObjectSize, because it has to be passed into the VMObject constructor, but it also works out some other odities. - make additional bytes arg to `new` operator mandatory, just for consistency - change naming of various bits - use constructors more aggressively to initialize VM* fields and avoid unnecessary setters - change VMArray to use numberOfFields to indexed elements. This means we do not support any fields on subclasses of array, which is fine with me. We don’t really support subclassing array in most SOMs anyway. And this way, VMArray is really just a VMObject from the perspective of GC Signed-off-by: Stefan Marr <[email protected]>
- fix typing for calls to NEW_INT Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
… VMInteger and VMDouble hashes Signed-off-by: Stefan Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works on various issues around GC, trying to find leaks/incorrect bits etc.
There are a lot of bits here that change code to slowly get clang-tidy become useful, which also includes reducing undefined behavior etc.
The major changes are:
IsMarkedValidfor more aggressive assertion checking