Adapt VMInvokable hierarchy to not be VMObjects #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- turn fields into proper integers to allow safe access in GC-critical methods - turn setters into arguments to constructor Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
|
It also gives a neat little performance gain: median -5% (min. -38%, max. 6%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since SOM changed and does not expose all the details it used to, we do not need to keep the various fields as SOM-level values.
This drastically simplifies things and avoids GC issues.
With the copying and generational GC, we do have to be very careful around cloning objects and walking objects that were already moved.
However, if we use VMIntegers to represent crucial info, that's rather hairy.
So, we just don't do that any longer.