Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various code style improvements to prevent mistakes #28

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Various code style improvements to prevent mistakes #28

merged 9 commits into from
Jul 23, 2024

Conversation

smarr
Copy link
Member

@smarr smarr commented Jul 23, 2024

  • allocate lexer as part of parser and avoid dynamic allocation
  • use override to allow compiler to check virtual functions
  • some naming and documentation changes
  • add debug helper: DebugGetClassName() for use in gdb/lldb

smarr added 9 commits July 23, 2024 12:54
@smarr
Allocate Lexer directly as part of Parser
31238ec 
Signed-off-by: Stefan Marr <[email protected]>
@smarr
Disable some more clang-tidy rules
3425fca 
Signed-off-by: Stefan Marr <[email protected]>
@smarr
Make GetHash a const operation for the moment
94a4d29 
Signed-off-by: Stefan Marr <[email protected]>
@smarr
Use override more consistently to avoid mistakes
d57f679 
Signed-off-by: Stefan Marr <[email protected]>
@smarr
Use requestGC and startGC instead of trigger GC
7642eb8 
Signed-off-by: Stefan Marr <[email protected]>
@smarr
Added DebugGetClassName helper
b52eb9d 
Signed-off-by: Stefan Marr <[email protected]>
@smarr
Document VMString constructor for VMSymbol and make address computati…
653e104 
…on more readable

Signed-off-by: Stefan Marr <[email protected]>
@smarr
Enable DEBUG=true in Xcode
2ee1c68 
Signed-off-by: Stefan Marr <[email protected]>
@smarr
Use C++ import
6db7313 
Signed-off-by: Stefan Marr <[email protected]>
@smarr smarr merged commit faad0f5 into SOM-st:master Jul 23, 2024
19 checks passed
@smarr smarr deleted the cleanup branch July 23, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smarr