Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for L1V4 cover page #195

Merged
merged 3 commits into from
Aug 2, 2021
Merged

Suggestions for L1V4 cover page #195

merged 3 commits into from
Aug 2, 2021

Conversation

jonrkarr
Copy link
Contributor

@jonrkarr jonrkarr commented Aug 2, 2021

  • More emphasis on the need for a common format to facilitate collaboration in modeling/simulation
  • Less emphasis on MIASE
  • Change description of MIASE from "proposes" to "outlines"
  • Brief summary of achievements of prior versions of SED-ML
  • More emphasis on innovations introduced in L1V4 and simultaneous expansion of the software ecosystem. I personally feel that the concretization of SED-ML and validation rules are key. These are critical to the vision of being able to exchange SED-ML between investigators/tools.

- More emphasis on the need for a common format to facilitate collaboration in modeling/simulation
- Less emphasis on MIASE
- Change description of MIASE from "proposes" to "outlines"
- Brief summary of achievements of prior versions of SED-ML
- More emphasis on innovations introduced in L1V4 and simultaneous expansion of the software ecosystem. I personally feel that the concretization of SED-ML and validation rules are key. These are critical to the vision of being able to exchange SED-ML between investigators/tools.
@jonrkarr jonrkarr requested a review from luciansmith August 2, 2021 16:10
Restored the original opening sentence, and reflowed some of the rest of the changes.

I did take out the personalized medicine and biological design bits, as they seemed a bit overly niche and trendy for a spec designed to cover a much wider spectrum of uses.
Copy link
Contributor

@luciansmith luciansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited! I generally kept the changes, but made some changes to hopefully make it flow better, and restored the original opening statement, which I felt was a better introduction to the spec.

@luciansmith
Copy link
Contributor

For some reason, I can't request you back as a re-reviewer? Anyway, happy to take further suggestions.

@jonrkarr
Copy link
Contributor Author

jonrkarr commented Aug 2, 2021

Looks good. I would just suggest rephrasing the first sentence to be a little more different from the first sentence of the L1V3 paper.

L1 V3

The creation of computational simulation experiments to inform modern biological research poses challenges to reproduce, annotate, archive, and share such experiments.

L1 V4 (current version)

The use of computational simulation experiments to inform modern biological research creates new challenges to annotate, archive, share and reproduce such experiments.

@luciansmith luciansmith merged commit d256cba into master Aug 2, 2021
@luciansmith luciansmith deleted the spec-abstract branch August 2, 2021 18:36
@luciansmith
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants