Improve docker build speed and caching #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The author of this PR, stefpiatek, is not an activated member of this organization on Codecov. |
milanmlft
approved these changes
Dec 4, 2024
Co-authored-by: Milan Malfait <[email protected]>
|
Followed renv's guide on multi-stage docker builds to separate the renv set up and installation so it would be cached across builds. |
stefpiatek
commented
Dec 9, 2024
stefpiatek
commented
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't have a look into the build time of the application, but duckdb takes forever to build. Running make with 4 cores decreased build time from ~3300s to ~1000s. Also changed order to allow the dependencies to be cached.