Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.7 release #16

Merged
merged 28 commits into from
Apr 12, 2024
Merged

2.7 release #16

merged 28 commits into from
Apr 12, 2024

Conversation

stefpiatek
Copy link
Contributor

Also added in some onboarding notes

@stefpiatek stefpiatek requested a review from skeating November 17, 2023 12:06
stefpiatek
stefpiatek commented Nov 17, 2023
View reviewed changes
docs/onboarding.md Outdated Show resolved Hide resolved
@stefpiatek stefpiatek closed this Nov 17, 2023
@stefpiatek stefpiatek reopened this Nov 17, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited by stefpiatek
Loading

PR checklist

Default guide for a PR (if multiple PRs for the work, only keep one version of it and link to it on the other PRs)

  • From the UCLH data science desktop, a validation run has been set off
  • load times
    in UCL teams has been populated with the run information
  • During the run, glowroot has been checked for any queries which are taking a substantial proportion of the
    total processing time. This can be useful to identify indexes that are required.
  • After the run, look for any unexpected errors in the etl_per_message_logging table, the error_search.sql file
    on the shared drive can be used for this \\sharefs6\UCLH6\EMAP\Shared\EmapSqlScripts\devops\error_search.sql.
    Create an issue if you find an unexpected exception and is not related to the changes you've made, otherwise
    fix them!
  • After the run, populate the end time in
    load times
  • Let Aasiyah know about the completed validation and give her information on the changes and where to start
    with the validation
  • Check validation report and give any feedback to Aasiyah if there are any changes needed on her side,
    iterate on getting the validation to match at least 99% (validation and emap code).

@stefpiatek
Add health endpoint to hl7 reader
9ae8443
@stefpiatek
Merge remote-tracking branch 'origin/main' into stef/2.7-release
d6ad25e 
# Conflicts:
#	docs/dev/img/core-message-processing.mmd
#	docs/dev/img/core-message-processing.svg
#	docs/dev/img/hl7-message-processing.mmd
#	docs/dev/img/hl7-message-processing.svg
#	docs/dev/img/hoover-development.mmd
#	docs/dev/img/hoover-development.svg
@stefpiatek
Document changing the actuator port in release SOP
9172484
@stefpiatek
Render mermaid inline in markdown
f47a3cc
@stefpiatek
Add batch processor to hoover diagram
36687c2
@stefpiatek
Add batch processor to hoover diagram
cf47db0
@stefpiatek
Tidy up formatting
dc26028
@stefpiatek
Try removing direction in mermaid
c138cad
@stefpiatek
Use rendered mermaid
aa9a616 
Diagrams seem to be too much for rendering inline in github?
@stefpiatek
Move onboarding file to dev
6f3010f
@stefpiatek
Fix mermaid styling?
3b65160
@stefpiatek
Add 2.7 release changelog
35aa945
@stefpiatek stefpiatek requested a review from skeating February 14, 2024 11:04
@stefpiatek stefpiatek merged commit 20e206f into main Apr 12, 2024
6 checks passed
@stefpiatek stefpiatek deleted the stef/2.7-release branch April 12, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeating skeating Awaiting requested review from skeating

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefpiatek @skeating