-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to uv
python tool
#579
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
=======================================
Coverage 87.41% 87.41%
=======================================
Files 76 76
Lines 3425 3425
=======================================
Hits 2994 2994
Misses 431 431 ☔ View full report in Codecov by Sentry. |
installed is a pre-requisite for running the system test script.
78af209
to
182490a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking really good - will be nice to switch to uv. Just a couple of comments at the minute, plus:
Do we need a mechanism to ensure that changes to pyproject.toml files are reflected in the uv.lock file so it can be committed too?
renovate should update both the pyproject.toml
and uv.lock
files at the same time
(Recording our earlier discussion) I was talking was about developer-initiated changes to |
before). Resources etc. seem to be getting included anyway without doing anything special, so remove the old setuptools directives and don't replace with anything.
I have changed all the |
Oh yes it does. This reverts commit 6df32e9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chef's kiss. Some suggestions, happy for you to merge without another review after you've addressed them to your satisfaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great. One minor suggestion around specifying the python version with uv
. Alternatively, we could add a .python-version
file that uv
will detect. Happy with whatever you decide
Co-authored-by: Paul Smith <[email protected]>
Description
Switch to using the
uv
Python package manager in all places: docker builds, GHA, and dev instructions.Known TODOs:
pip
uv sync --all-extras --all-packages
is currently needed to get pytest. I'd expect just extras to be needed. Do I need to add extras section to root pyproject and link to workspace extras?pyproject.toml
files are reflected in theuv.lock
file so it can be committed too?setuptools
in pixl_dcmd just for the sake of pydicom? Shouldn't it be responsible for its own dependencies?Type of change
Please delete options accordingly to the description.
Suggested Checklist
main
branch.squash and merge