pkcs8: provide PrivateKeyInfoRef/PrivateKeyInfoOwned #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
16 tasks
baloo
commented
Aug 18, 2024
pkcs8/src/private_key_info.rs
Outdated
| reader.read_nested(header.length, |reader| { | ||
| // Parse and validate `version` INTEGER. | ||
| let version = Version::decode(reader)?; | ||
| let algorithm = reader.decode()?; | ||
| let private_key = OctetStringRef::decode(reader)?.into(); | ||
| let private_key: &[u8] = OctetStringRef::decode(reader)?.into(); | ||
| let private_key = Key::try_from(private_key)?; |
There was a problem hiding this comment.
yeah, this could be an OctetString or OctetStringRef instead. I don't know what I was thinking last year.
There was a problem hiding this comment.
clippy seems to suggest From over TryFrom
There was a problem hiding this comment.
Yeah, clippy lead me to rethink my position on OctetString actually.
I rewrote the backing storage in the follow up commit.
baloo
force-pushed
the
baloo/pkcs8/owned-ref-private-key
branch
from
71c9927 to
8191fb6
Compare
|
and that is now causing problems all over the place, sweet. |
tarcieri
reviewed
Aug 19, 2024
baloo
added a commit
to baloo/signatures
that referenced
this pull request
Aug 19, 2024
baloo
added a commit
to baloo/RSA
that referenced
this pull request
Aug 19, 2024
baloo
added a commit
to baloo/traits
that referenced
this pull request
Aug 19, 2024
baloo
force-pushed
the
baloo/pkcs8/owned-ref-private-key
branch
from
5e9b14d to
bcf2035
Compare
baloo
commented
Aug 19, 2024
Comment on lines
+374
to
+385
| pub trait BitStringLike { | ||
| fn as_bit_string(&self) -> BitStringRef<'_>; | ||
| } | ||
|
|
||
| impl<'a> BitStringLike for BitStringRef<'a> { | ||
| fn as_bit_string(&self) -> BitStringRef<'_> { | ||
| BitStringRef::from(self) | ||
| } | ||
| } |
There was a problem hiding this comment.
I could not figure out a way to express this with the traits implemented by both BitStringRef and BitString.
There was a problem hiding this comment.
In the interest of getting this PR across the finish line I'll go ahead and merge this, but I think we should definitely find a better solution, and it should go in the der crate.
Something like OwnedToRef but impl'd for both the owned and reference types so it can be used interchangeably, and for any of the *Ref types and not just specialized to BitString*.
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
baloo
force-pushed
the
baloo/pkcs8/owned-ref-private-key
branch
from
fb4becf to
3400a03
Compare
tarcieri
approved these changes
Sep 4, 2024
baloo
added a commit
to baloo/traits
that referenced
this pull request
Sep 5, 2024
baloo
added a commit
to baloo/signatures
that referenced
this pull request
Sep 5, 2024
baloo
added a commit
to baloo/traits
that referenced
this pull request
Sep 5, 2024
baloo
added a commit
to baloo/traits
that referenced
this pull request
Sep 5, 2024
baloo
added a commit
to baloo/traits
that referenced
this pull request
Sep 5, 2024
baloo
added a commit
to baloo/signatures
that referenced
this pull request
Sep 5, 2024
tarcieri
pushed a commit
to RustCrypto/traits
that referenced
this pull request
Sep 5, 2024
baloo
added a commit
to baloo/RSA
that referenced
this pull request
Sep 5, 2024
tarcieri
pushed a commit
to RustCrypto/RSA
that referenced
this pull request
Sep 5, 2024
baloo
added a commit
to baloo/formats
that referenced
this pull request
Sep 6, 2024
- pkcs1 `0.8.0-rc.1` - pkcs8 `0.11.0-rc.1` - sec1 `0.8.0-rc.1` This comes after the merge of API breaks on pkcs8 ([RustCrypto#1483]) [RustCrypto#1483]: RustCrypto#1483
baloo
added a commit
that referenced
this pull request
Sep 6, 2024
baloo
added a commit
to baloo/signatures
that referenced
this pull request
Sep 6, 2024
This bump the following dependencies: - pkcs8 0.11.0-rc.0 -> 0.11.0-rc.1 - elliptic-curve 0.14.0-pre.6 -> 0.14.0-rc.0 This is a followup on breaking changes made on pkcs8 (RustCrypto/formats#1483).
tarcieri
pushed a commit
to RustCrypto/signatures
that referenced
this pull request
Sep 6, 2024
This bump the following dependencies: - pkcs8 0.11.0-rc.0 -> 0.11.0-rc.1 - elliptic-curve 0.14.0-pre.6 -> 0.14.0-rc.0 This is a followup on breaking changes made on pkcs8 (RustCrypto/formats#1483).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1183 mark 2
This makes the
PrivateKeyInfogeneric over its backing storage, and this provides two version of it, namelyPrivateKeyInfoRefandPrivateKeyInfoOwnedrespectively borrowing the value and owning the storage of the value.followup PRs: