Int - inv_mod
#737
Draft
Int - inv_mod
#737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-3milabs
commented
Jan 10, 2025
Comment on lines
-446
to
449
| pub trait InvMod: Sized { | ||
| pub trait InvMod<Rhs = Self, Output = Self>: Sized { | ||
| /// Compute `1 / self mod p`. | ||
| fn inv_mod(&self, p: &Self) -> CtOption<Self>; | ||
| fn inv_mod(&self, p: &Rhs) -> CtOption<Output>; | ||
| } |
There was a problem hiding this comment.
@tarcieri this is the non-breaking type approach for this trait. I think a more readable solution would be to add the type Modulus; and type Output; as trait types. Wdyt?
There was a problem hiding this comment.
making Output an associated type makes sense, however Rhs is typically a generic parameter in core arithmetic traits, which allows overlapping impls potentially (though I'm not sure that would be of use here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
Int::inv_modoperation.Replaces #727