Additional methods for Integer and Monty
#533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Dec 29, 2023
tarcieri
reviewed
Dec 29, 2023
Comment on lines
+166
to
+169
| /// The value `1` with the same precision as `other`. | ||
| fn one_like(other: &Self) -> Self { | ||
| Self::from_limb_like(Limb::ONE, other) | ||
| } |
There was a problem hiding this comment.
I've wondered if we should have a One trait, similar to num_traits::One.
The only reason we don't use num_traits::One is so is_one can return Choice, as it were.
There was a problem hiding this comment.
Seems logical to have such a trait. If we're redefining num_traits::Zero, might as well redefine One too.
tarcieri
reviewed
Dec 29, 2023
tarcieri
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integer::from_limb_like(),one_like(), andZero::zero_like(). This is needed in #39Monty::params()andas_montgomery()I do not entirely like
from_limb_like, but that's all I could come up with.