Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat the code with uncrustify #158

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Reformat the code with uncrustify #158

merged 3 commits into from
Oct 3, 2024

Conversation

bjsowa
Copy link
Collaborator

@bjsowa bjsowa commented Oct 2, 2024

No description provided.

@bjsowa bjsowa marked this pull request as ready for review October 3, 2024 01:05
sea-bass
sea-bass approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting is so weird with uncrustify, especially the spaces in e.g. const int & val in function headers... but it's automated linting, which is better than nothing. Thanks!

@bjsowa
Copy link
Collaborator Author

bjsowa commented Oct 3, 2024

Uncrustify is commonly used accross ROS2 packages and provides more flexibility than some other tools like clang-format. That's why I opted to use it.

@bjsowa bjsowa merged commit 140ff53 into ros2 Oct 3, 2024
16 checks passed
@bjsowa bjsowa deleted the style-changes branch October 3, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea-bass sea-bass sea-bass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjsowa @sea-bass