[Paywalls V2] Allow overriding of font size on paywall #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
changed the base branch from
main
to
paywalls-v2/ui-config-colors-light-and-dark
joshdholtz
force-pushed
the
paywalls-v2/ui-config-colors-light-and-dark
branch
from
cb94a09 to
5c70b03
Compare
joshdholtz
force-pushed
the
paywalls-v2/overriding-font-sizes
branch
from
0254a82 to
de08a5f
Compare
Base automatically changed from
paywalls-v2/ui-config-colors-light-and-dark
to
main
January 13, 2025 12:23
…eoretically this should work
joshdholtz
force-pushed
the
paywalls-v2/overriding-font-sizes
branch
from
de08a5f to
f5f4ed8
Compare
JayShortway
reviewed
Jan 13, 2025
Comment on lines
+58
to
+67
| case .headingXXL: fontSize = fontSizeOverrides?.headingXXL.asCGFloat ?? 40 | ||
| case .headingXL: fontSize = fontSizeOverrides?.headingXL.asCGFloat ?? 34 | ||
| case .headingL: fontSize = fontSizeOverrides?.headingL.asCGFloat ?? 28 | ||
| case .headingM: fontSize = fontSizeOverrides?.headingM.asCGFloat ?? 24 | ||
| case .headingS: fontSize = fontSizeOverrides?.headingS.asCGFloat ?? 20 | ||
| case .headingXS: fontSize = fontSizeOverrides?.headingXS.asCGFloat ?? 16 | ||
| case .bodyXL: fontSize = fontSizeOverrides?.bodyXL.asCGFloat ?? 18 | ||
| case .bodyL: fontSize = fontSizeOverrides?.bodyL.asCGFloat ?? 17 | ||
| case .bodyM: fontSize = fontSizeOverrides?.bodyM.asCGFloat ?? 15 | ||
| case .bodyS: fontSize = fontSizeOverrides?.bodyS.asCGFloat ?? 13 |
There was a problem hiding this comment.
I'd still like to discuss the backend just sending the font size as a number (e.g. 40 instead of heading_xxl) in the text component.
{
- "font_size": "heading_xxl",
+ "font_size": 40,
"type": "text"
}The dashboard can still have font size names of course. The SDK just doesn't need to know about them.
Benefits I see:
- avoids the complexity added in this PR
- allows us to make changes to the list of font size names without needing SDK updates
- allows us to fine-tune font sizes (even between platforms) without needing SDK updates
I've added an item to our weekly today 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow overriding of font sizes per paywall
Description
New
fontSizeOverrideonPaywallComopnentsDatabasepaywall is onheading_xxl,heading_xl,body_l, etc)