-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Paywalls V2] Updated outdated image component properties #4649
Conversation
1 build increased size
Paywalls 1.0 (1)
|
Item | Install Size Change |
---|---|
RevenueCatUI.ImageComponentViewModel.ImageComponentViewModel | ⬆️ 29.9 kB |
DYLD.String Table | ⬆️ 8.8 kB |
Code Signature | ⬆️ 5.3 kB |
RevenueCatUI.StackComponentViewModel.StackComponentViewModel | ⬆️ 3.3 kB |
DYLD.Exports | ⬆️ 1.0 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
e6ea745
to
f852034
Compare
f852034
to
162df23
Compare
@joshdholtz Why was the gradient overlay removed? That could enable some designs, especially if one of the gradient colors is more transparent than the other. @tonidero Would you be able to track adding padding, margin, border and shadow to Android? 🙏 |
@joshdholtz Oh nevermind, I see it's a |
@JayShortway The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sure thing! Will take a look to add them tomorrow 👍 |
Motivation
Image component was missing some new properties (and had some outdated ones)
Description