Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paywalls V2] Updated outdated image component properties #4649

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Jan 11, 2025

Motivation

Image component was missing some new properties (and had some outdated ones)

Description

  • Removed:
    • Gradient overlay
    • Max height
  • Added:
    • Color overlay
    • Padding
    • Margin
    • Border
    • Shadow

⚠️ Follow PR to actually use all these properties

@joshdholtz joshdholtz changed the base branch from main to paywalls-v2/fix-stack-infinity January 11, 2025 20:27
Copy link

emerge-tools bot commented Jan 11, 2025

1 build increased size

Name Version Download Change Install Change Approval
Paywalls
com.revenuecat.PaywallsTester
1.0 (1) 11.0 MB ⬆️ 65.3 kB (0.6%) 40.9 MB ⬆️ 207.0 kB (0.51%) N/A

Paywalls 1.0 (1)
com.revenuecat.PaywallsTester

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 207.0 kB (0.51%)
Total download size change: ⬆️ 65.3 kB (0.6%)

Largest size changes

Item Install Size Change
RevenueCatUI.ImageComponentViewModel.ImageComponentViewModel ⬆️ 29.9 kB
DYLD.String Table ⬆️ 8.8 kB
Code Signature ⬆️ 5.3 kB
RevenueCatUI.StackComponentViewModel.StackComponentViewModel ⬆️ 3.3 kB
DYLD.Exports ⬆️ 1.0 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

Base automatically changed from paywalls-v2/fix-stack-infinity to main January 13, 2025 11:33
@joshdholtz joshdholtz force-pushed the paywalls-v2/update-image-properties branch from e6ea745 to f852034 Compare January 13, 2025 11:48
@joshdholtz joshdholtz marked this pull request as ready for review January 13, 2025 12:34
@joshdholtz joshdholtz force-pushed the paywalls-v2/update-image-properties branch from f852034 to 162df23 Compare January 13, 2025 12:35
@joshdholtz joshdholtz requested review from a team January 13, 2025 12:35
@JayShortway
Copy link
Member

@joshdholtz Why was the gradient overlay removed? That could enable some designs, especially if one of the gradient colors is more transparent than the other.

@tonidero Would you be able to track adding padding, margin, border and shadow to Android? 🙏

@JayShortway
Copy link
Member

@joshdholtz Oh nevermind, I see it's a ColorScheme now. Ha, Android was ahead on this one 💪 thanks to @tonidero!

@joshdholtz
Copy link
Member Author

@joshdholtz Why was the gradient overlay removed? That could enable some designs, especially if one of the gradient colors is more transparent than the other.

@tonidero Would you be able to track adding padding, margin, border and shadow to Android? 🙏

@JayShortway The gradient_overlay was the OOOLLDDDDDD property 😬 It's successor is color_overlay which could be a solid color (hex) or an gradient (linear or radial)

Copy link
Member

@JayShortway JayShortway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshdholtz joshdholtz merged commit daa8663 into main Jan 13, 2025
10 checks passed
@joshdholtz joshdholtz deleted the paywalls-v2/update-image-properties branch January 13, 2025 13:38
@tonidero
Copy link
Contributor

@tonidero Would you be able to track adding padding, margin, border and shadow to Android? 🙏

Sure thing! Will take a look to add them tomorrow 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants