-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use custom label for CompatibilityContentUnavailableView #4647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! It does mean we have a liiitle more vertical padding now (see the screenshots) but it doesn't look wrong to my eye
RevenueCatUI/CustomerCenter/Views/CompatibilityContentUnavailableView.swift
Outdated
Show resolved
Hide resolved
(approved but we should fix the linting + approve the new snapshots before merging) |
} icon: { | ||
iconView | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious 🤔. Would it be possible to remove the if let description
and keep only this?
ContentUnavailableView {
Label {
titleView
} icon: {
iconView
}
}
description: { description }
I don't know if nil
would have the same effect as EmptyView()
(which is the default value for the description
parameter when the parameter is not included)
Motivation
This PR tries to address #4638.
Description
For some reason,
ContentUnavailableView
truncates the label. I've tried usinglineLimit(nil)
over theLabel
, but that didn't work. This seems to do the trick.fixedSize(vertical:true)
forces the view to grow vertically to the needed height.