[Paywalls V2] Fix vstack and hstack growing size when fit #4646
+100
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpallares
reviewed
Jan 13, 2025
| // self.modifier(SizeModifier(size: size, | ||
| // hortizontalAlignment: alignment, | ||
| // verticalAlignment: alignment)) | ||
| // } |
There was a problem hiding this comment.
Perhaps this commented out code can be removed
ajpallares
reviewed
Jan 13, 2025
| @@ -58,7 +58,8 @@ struct TextComponentView: View { | |||
| .multilineTextAlignment(style.textAlignment) | |||
| .foregroundColorScheme(style.color, uiConfigProvider: self.viewModel.uiConfigProvider) | |||
| .padding(style.padding) | |||
| .size(style.size, alignment: style.horizontalAlignment) | |||
| .size(style.size, | |||
| horizontalAlignment: style.horizontalAlignment) | |||
There was a problem hiding this comment.
Don't we need to also pass the verticalAlignment parameter here?
.size(style.size,
horizontalAlignment: style.horizontalAlignment,
verticalAlignment: style.verticalAlignment)
There was a problem hiding this comment.
I also thought the same thing at first too 😅 But... text doesn't have a vertical alignment property for its content 🤷♂️
There was a problem hiding this comment.
Oh, you're totally right! Thanks for the clarification!
There was a problem hiding this comment.
Oh, you're totally right! Thanks for the clarification!
Np np! Thanks for asking about that because it does seem like an odd change at first 😇
JayShortway
reviewed
Jan 13, 2025
MarkVillacampa
approved these changes
Jan 13, 2025
ajpallares
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Vertical and horizontal stacks would act as fill when set as fit
Description