Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and clarify the dev setup process on a new machine #4643

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ekurutepe
Copy link
Contributor

@ekurutepe ekurutepe commented Jan 9, 2025

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

Motivation

I ran into a few issues while setting up my new Mac. I'm sure I'm not the only and these initial setup issues are super frustrating.

Description

  • add Sequoia to the supported platforms
  • specify a ruby version for the gemfile
  • add the need to install the gems in the instructions
  • ensure the .git/hooks dir exists before copying the hook

@ekurutepe ekurutepe marked this pull request as draft January 9, 2025 11:23
@ekurutepe ekurutepe marked this pull request as ready for review January 9, 2025 11:52
@ekurutepe ekurutepe requested a review from tonidero January 9, 2025 11:52
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note about whether we should force the update to ruby 3.2.0... It might be worth updating in any case so we are in a newer version, but just making sure I understand the issues you found.

fastlane/Fastfile Show resolved Hide resolved
@@ -1,5 +1,7 @@
source "https://rubygems.org"

ruby '~> 3.2.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this might force devs to update their ruby version... Was this needed for some dependency? I've been able to run fine from 3.1.2 with a clean clone, so not sure if it's needed. Were you finding errors in ruby 3.1.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other way around. I had ruby 3.4 installed by default and it was causing compatibility issues with some gems. I think it makes sense to fix the version to the same version as we're using on CI. (which was a mix of 3.2.0 and 3.1.2 before) I think it's ok to encourage devs to use a compatible ruby version since this is only applies to contributors, not for developers using purchase-ios in their apps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, I was just using 3.1.2 but I don't mind too much to update. Might want to give a heads up in #guild-sdks but looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants