-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and clarify the dev setup process on a new machine #4643
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note about whether we should force the update to ruby 3.2.0... It might be worth updating in any case so we are in a newer version, but just making sure I understand the issues you found.
@@ -1,5 +1,7 @@ | |||
source "https://rubygems.org" | |||
|
|||
ruby '~> 3.2.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm this might force devs to update their ruby version... Was this needed for some dependency? I've been able to run fine from 3.1.2 with a clean clone, so not sure if it's needed. Were you finding errors in ruby 3.1.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other way around. I had ruby 3.4 installed by default and it was causing compatibility issues with some gems. I think it makes sense to fix the version to the same version as we're using on CI. (which was a mix of 3.2.0 and 3.1.2 before) I think it's ok to encourage devs to use a compatible ruby version since this is only applies to contributors, not for developers using purchase-ios
in their apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, I was just using 3.1.2 but I don't mind too much to update. Might want to give a heads up in #guild-sdks but looks good!
Checklist
purchases-android
and hybridsMotivation
I ran into a few issues while setting up my new Mac. I'm sure I'm not the only and these initial setup issues are super frustrating.
Description
.git/hooks
dir exists before copying the hook