[Customer Center] Hack week: add contact support button to customer center #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
aboedo
reviewed
Jan 9, 2025
Comment on lines
+68
to
+76
| #if DEBUG | ||
| return true | ||
| #else | ||
| guard !Self.isAppExtension, | ||
| let application = Self.sharedUIApplication else { | ||
| return false | ||
| } | ||
| return application.canOpenURL(url) | ||
| #endif |
There was a problem hiding this comment.
curious about this part - shouldn't it still be false for app extensions even when in debug?
There was a problem hiding this comment.
this is a hack to make this return true in SwiftUI previews. Otherwise it would just return false since previews can't open URLs.
vegaro
reviewed
Jan 10, 2025
There was a problem hiding this comment.
I do think we have to add the contact support button but with this changes, it will be hardcoded for everyone.
Instead I think we should make it one of the paths in the dashboard (same as "Manage subscriptions", or "Request a refund"), so it's optional and dynamically added by the ManageSubscriptionsButtonsView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
It seems like we have the ability to open system email client to contact support but we were not surfacing this for the users. See the discussion: https://revenuecat.slack.com/archives/C072SLPSTQS/p1736178563670389
Description
Adds a user tappable ContactSupportButton to customer center at the top level for all purchase states.