Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(970): moves notices for joining to its own component #972

Merged
merged 5 commits into from
Jan 10, 2025
Merged

refactor(970): moves notices for joining to its own component #972

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84ba5d2
feat(970): moves notices for joining to its own component
ankushdharkar Jan 6, 2025
c7936b0
Merge branch 'develop' into 970-update-homepage
iamitprakash Jan 6, 2025
18867d8
Merge branch 'develop' into 970-update-homepage
Achintya-Chatterjee Jan 6, 2025
4e28b4c
refactor(970): added review changes: year - 2024
ankushdharkar Jan 7, 2025
4249537
refactor(970): fixed messaging for joining
ankushdharkar Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/components/join-section.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,13 @@
{{!-- If something goes wrong, we can enable a flag to restore previous behaviour --}}
{{!-- TODO: Clean up by Jan, 2025 --}}
<p data-test-join-later-text class='join__later-text'>

{{#if this.isDevMode}}
We're currently not accepting new applications. Please check back in 2024.
We're currently not accepting new applications. Please check back in 2025.
ankushdharkar marked this conversation as resolved.
Show resolved Hide resolved
{{else}}
<NoticeForJoining />
{{/if}}
</p>

</section>
{{/if}}
1 change: 1 addition & 0 deletions app/templates/subscribe.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
</div>
{{else}}
<h1>Join the Real Dev Squad Community</h1>

<p class="notification__text">
{{!-- NOTE: This has the new code on feature flag off. --}}
{{!-- If something goes wrong, we can enable a flag to restore previous behaviour --}}
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.