Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor application status card #833

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Refactor application status card #833

merged 10 commits into from
Jan 18, 2024

Conversation

vinit717
Copy link
Member

@vinit717 vinit717 commented Jan 10, 2024

Date: 10-01-2024

Developer Name: vinit


Issue Ticket Number:-

Description:

Refactor the status card to show icons for different statuses

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

image
image
image

follow up Issue

Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fddee53
Status: ✅  Deploy successful!
Preview URL: https://68005361.www-rds.pages.dev
Branch Preview URL: https://refactor-status-card.www-rds.pages.dev

View logs

@vinit717 vinit717 self-assigned this Jan 10, 2024
@satyam73
Copy link
Member

Can we have rejected icon color to be red?

@vinit717
Copy link
Member Author

Can we have rejected icon color to be red?

Can't get it can you elaborate more?

@satyam73
Copy link
Member

Can we have rejected icon color to be red?

Can't get it can you elaborate more?

This icon will look good in red imo
image

@satyam73 satyam73 merged commit dd1df32 into develop Jan 18, 2024
3 checks passed
@satyam73 satyam73 deleted the refactor/status-card branch January 18, 2024 18:14
@vinit717 vinit717 mentioned this pull request Jan 19, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants