-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate signup api in onboarding #735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
…site-www into onboarding/signup-api
…site-www into onboarding/signup-api
…quad/website-www into onboarding/signup-api
lakshayman
requested changes
Dec 16, 2023
…site-www into onboarding/signup-api
lakshayman
requested changes
Dec 19, 2023
prakashchoudhary07
requested changes
Dec 20, 2023
satyam73
reviewed
Dec 22, 2023
satyam73
reviewed
Dec 22, 2023
satyam73
reviewed
Dec 22, 2023
satyam73
reviewed
Dec 22, 2023
satyam73
reviewed
Dec 22, 2023
satyam73
reviewed
Dec 22, 2023
satyam73
reviewed
Dec 22, 2023
satyam73
reviewed
Dec 22, 2023
satyam73
reviewed
Dec 22, 2023
…quad/website-www into onboarding/signup-api
satyam73
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ticket Number
Description
Integrate the signup API and remove the username generate button as per Ankush's instruction and also remove developer to pass in patch API as latter we can send it other API which I approved by superuser only
Documentation Updated?
If your feature adds a new API, then documentation related to the feature like API-Contracts, and Data-models must be updated.
Breaking Changes
If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.
Development Tested?
Confirm whether the changes have been tested locally during development.
Tested in Staging?
Indicate whether the changes have been tested in the staging environment.
Under Feature Flag
Specify if the changes are currently under a feature flag.
Database Changes
Indicate whether the changes include modifications to the database.
Screenshots
emberdata-signup.mp4
Test Coverage
Additional Notes
Include any additional notes, considerations, or explanations that might be helpful for reviewers.