Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate signup api in onboarding #735

Merged
merged 31 commits into from
Dec 27, 2023
Merged

Conversation

vinit717
Copy link
Member

@vinit717 vinit717 commented Nov 6, 2023

Issue Ticket Number

Description

Integrate the signup API and remove the username generate button as per Ankush's instruction and also remove developer to pass in patch API as latter we can send it other API which I approved by superuser only

Documentation Updated?

  • Yes
  • No

If your feature adds a new API, then documentation related to the feature like API-Contracts, and Data-models must be updated.

Breaking Changes

  • Yes
  • No

If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.

Development Tested?

  • Yes
  • No

Confirm whether the changes have been tested locally during development.

Tested in Staging?

  • Yes
  • No

Indicate whether the changes have been tested in the staging environment.

Under Feature Flag

  • Yes
  • No

Specify if the changes are currently under a feature flag.

Database Changes

  • Yes
  • No

Indicate whether the changes include modifications to the database.

Screenshots

emberdata-signup.mp4

Test Coverage

image

image

Additional Notes

Include any additional notes, considerations, or explanations that might be helpful for reviewers.

@vinit717 vinit717 self-assigned this Nov 6, 2023
@vinit717 vinit717 marked this pull request as draft November 6, 2023 12:03
@vinit717 vinit717 changed the title add signup api Integrate signup api in onboarding Nov 6, 2023
Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1eb7b00
Status: ✅  Deploy successful!
Preview URL: https://130d7162.www-rds.pages.dev
Branch Preview URL: https://onboarding-signup-api.www-rds.pages.dev

View logs

@vinit717 vinit717 marked this pull request as ready for review December 16, 2023 07:03
app/components/signup-steps/step-one.js Show resolved Hide resolved
app/services/onboarding.js Outdated Show resolved Hide resolved
tests/integration/components/signup-steps/step-one-test.js Outdated Show resolved Hide resolved
tests/unit/services/onboarding-test.js Outdated Show resolved Hide resolved
app/services/onboarding.js Outdated Show resolved Hide resolved
app/services/onboarding.js Outdated Show resolved Hide resolved
tests/unit/services/onboarding-test.js Show resolved Hide resolved
tests/unit/services/onboarding-test.js Outdated Show resolved Hide resolved
tests/unit/services/onboarding-test.js Outdated Show resolved Hide resolved
tests/unit/services/onboarding-test.js Outdated Show resolved Hide resolved
app/serializers/user.js Outdated Show resolved Hide resolved
app/components/signup-steps/step-one.js Show resolved Hide resolved
@satyam73 satyam73 merged commit f41ad60 into develop-ember Dec 27, 2023
1 check passed
@satyam73 satyam73 deleted the onboarding/signup-api branch December 27, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants