Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Live-Site] Feat/event logs api #723

Merged
merged 5 commits into from
Nov 4, 2023
Merged

Conversation

satyam73
Copy link
Member

@satyam73 satyam73 commented Oct 31, 2023

Issue #706

Closes #706

Date: 31-10-23

Developer Name: Satyam Bajpai

PR Number(s):- #723

Issue Ticket Number:- #706

Backend changes

  • Yes
  • No

Frontend Changes

  • Yes
  • No

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Deployment notes
Any special instructions for the deployment(N/A)

Tested in staging

  • Yes
  • No

Related backend PR

What is the change?

In this PR I have integrated API for event kickout logs and rendered the data in ui.

Is Development Tested?

  • Yes
  • No

Before / After Change Screenshots

event-log-integration-final.mp4

Test Snapshots

image

Note :
What to delete and what not to

  • Keep the headings and answer the questions.
  • Delete the examples
  • Delete the description below headings What is the change? & Before/After Screenshots

@satyam73 satyam73 changed the base branch from develop to develop-ember October 31, 2023 18:54
Copy link

cloudflare-workers-and-pages bot commented Oct 31, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d7b1595
Status: ✅  Deploy successful!
Preview URL: https://9f0b9837.www-rds.pages.dev
Branch Preview URL: https://feat-event-logs-api.www-rds.pages.dev

View logs

@satyam73 satyam73 marked this pull request as ready for review November 1, 2023 09:27
@shubhamsinghbundela
Copy link
Contributor

Can you please add screenshot or video in description

Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve PR description and why there are no tests

@satyam73 satyam73 changed the title Feat/event logs api [Live-Site] Feat/event logs api Nov 3, 2023
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR details are missing, please add it

@satyam73 satyam73 requested a review from iamitprakash November 4, 2023 18:47
@iamitprakash iamitprakash merged commit 160ddd0 into develop-ember Nov 4, 2023
2 checks passed
@iamitprakash iamitprakash deleted the feat/event-logs-api branch November 4, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants