Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navpills alignment to center #719

Conversation

samyakshah3008
Copy link
Contributor

Issue

Closes #718

What is the change?

  • Navpills are now aligned to center. Initially the left section alignment was not consistent with the right section of Navbar. Hence this PR aims to fix it.

Is Development Tested?

  • Yes
  • No

Before/After Change Screenshots:

Before :

image

After :

image

@shubhamjaintech
Copy link

Looks good to me! @samyakshah3008

joyguptaa
joyguptaa previously approved these changes Oct 28, 2023
Copy link

@joyguptaa joyguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samyakshah3008
Copy link
Contributor Author

Thank you @shubhamjaintech @ardourApeX for reviews!

satyam73
satyam73 previously approved these changes Oct 28, 2023
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix failing test case first

@satyam73
Copy link
Member

Closing this since we've migrated our site to Ember and this PR was opened for Vanilla site

@satyam73 satyam73 closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI]: Navbar pills not aligned
6 participants