Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modeified css for role choose card #716

Conversation

skt17
Copy link

@skt17 skt17 commented Oct 26, 2023

Issue

Example : Closes #<issue_number>

What is the change?

Provide a small description in points of what did you change

Example :
  • Done this
  • Made these changes

Is Development Tested?

  • Yes
  • No

Before / After Change Screenshots

For visual or interaction changes. Please provide a video / screenshot.

Example:

Before :
Image/Video

After :
Image/Video

Note :
What to delete and what not to

  • Keep the headings and answer the questions.
  • Delete the examples
  • Delete the description below headings What is the change? & Before/After Screenshots

Comment on lines 216 to +219
.card {
padding: 20px 10px;
padding: 20px 20px;
width: 90%;
align-items: normal;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why .card has been changed?
If somewhere else this class has been used it will break the UI there as it is general class which I told you I guess

@shubhamsinghbundela
Copy link
Contributor

please Fill the description

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper PR details are missing

@satyam73
Copy link
Member

Closing this PR in respect of this PR #748

@satyam73 satyam73 closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants