Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Live-Site] - make sidebar collapsible #613

Closed
wants to merge 24 commits into from
Closed

[Live-Site] - make sidebar collapsible #613

wants to merge 24 commits into from

Conversation

Pratiyushkumar
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar commented Aug 30, 2023 •
edited
Loading

Issue

What is the change?

Currently, in desktop mode, the sidebar which contains a list of participants who join the live streaming, sidebar should be collapsible so that the video player screen can be enlarged

Is Development Tested?

  • Yes
  • No

Before / After Change Screenshots

bandicam.2023-10-16.14-40-19-829.mp4

@Pratiyushkumar Pratiyushkumar marked this pull request as ready for review August 30, 2023 02:04
@Pratiyushkumar Pratiyushkumar changed the title made sidebar collapsible [Live-Site] - make sidebar collapsible Aug 30, 2023
@Pratiyushkumar Pratiyushkumar self-assigned this Aug 30, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 30, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b779742
Status: ✅  Deploy successful!
Preview URL: https://649526cd.www-rds.pages.dev
Branch Preview URL: https://feature-collapse-sidebar.www-rds.pages.dev

View logs

@satyam73
Copy link
Member

image
The menu button here isn't looking good.
Can we improve on this?
Also add matching color to menu icon, and change the icon to stroked one, right now it's filled.

@Pratiyushkumar
Copy link
Contributor Author

image The menu button here isn't looking good. Can we improve on this? Also add matching color to menu icon, and change the icon to stroked one, right now it's filled.

@satyam73 I have resolved the merge conflict but as per your suggestion on PR, can you please give some idea as to how I can improve more...I did what best I could do but if any improvement is required then request you to give some idea...

iamitprakash
iamitprakash previously approved these changes Aug 31, 2023
View reviewed changes
@satyam73 satyam73 force-pushed the 536-live-site-move-to-room-codes branch from d90578a to 3f7567e Compare September 1, 2023 18:08
Base automatically changed from 536-live-site-move-to-room-codes to develop-ember September 1, 2023 18:12
@rohan09-raj rohan09-raj dismissed iamitprakash’s stale review September 1, 2023 18:12

The base branch was changed.

@satyam73 satyam73 linked an issue Sep 5, 2023 that may be closed by this pull request
[Live-Site] - make sidebar collapsible #609
Open
satyam73
satyam73 requested changes Sep 5, 2023
View reviewed changes
app/components/live-sidebar.hbs Outdated Show resolved Hide resolved
app/components/live-sidebar.hbs Outdated Show resolved Hide resolved
app/components/live-sidebar.hbs Outdated Show resolved Hide resolved
app/styles/live-sidebar.module.css Outdated Show resolved Hide resolved
app/styles/live.module.css Outdated Show resolved Hide resolved
app/styles/live.module.css Outdated Show resolved Hide resolved
app/styles/live.module.css Outdated Show resolved Hide resolved
app/components/live-sidebar.js Outdated Show resolved Hide resolved
app/controllers/live.js Outdated Show resolved Hide resolved
@satyam73
Copy link
Member

satyam73 commented Sep 6, 2023

These are the pointer which needs work thereafter we can merge this PR.

  • Menu icon is coming on center from breakpoint 1235
    image

  • Can we do menu icon like this instead of it roaming around anywhere in the space? It looks more into the UI.
    image

  • Tests are failing please fix them.

iamitprakash
iamitprakash previously approved these changes Oct 16, 2023
View reviewed changes
@satyam73
Copy link
Member

Why arrow is showing in sidebar if sidebar is not of mobile version?
image

@satyam73
Copy link
Member

Can we use relatable icon in the bar?
Something as in image
image

https://icon-sets.iconify.design/?query=full

satyam73
satyam73 requested changes Oct 22, 2023
View reviewed changes
app/components/live-sidebar.hbs Show resolved Hide resolved
app/styles/live-sidebar.module.css Show resolved Hide resolved
app/styles/live-sidebar.module.css Outdated Show resolved Hide resolved
app/styles/live-sidebar.module.css Outdated Show resolved Hide resolved
app/styles/live-sidebar.module.css Show resolved Hide resolved
app/styles/live.module.css Show resolved Hide resolved
app/styles/live.module.css Show resolved Hide resolved
@Pratiyushkumar
Copy link
Contributor Author

Why arrow is showing in sidebar if sidebar is not of mobile version? image

this arrow is for the options given on top of the screen and not due to my code
#613 (comment)

@Pratiyushkumar
Copy link
Contributor Author

closing this PR as raised new PR because due to merge conflicts the application got a lot of bugs
#720

@Pratiyushkumar
Copy link
Contributor Author

closing this PR as raised new PR because due to merge conflicts the application got a lot of bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyam73 satyam73 satyam73 requested changes

@shubhamsinghbundela shubhamsinghbundela shubhamsinghbundela left review comments

@iamitprakash iamitprakash iamitprakash left review comments

Assignees

@Pratiyushkumar Pratiyushkumar

Labels
live-site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Live-Site] - make sidebar collapsible
4 participants
@Pratiyushkumar @satyam73 @iamitprakash @shubhamsinghbundela