refactor : using msw instead of jest.mock of useUserData hook in tests. #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shah-Arsalan is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
bharati-21
reviewed
Jul 25, 2023
| @@ -124,7 +122,8 @@ describe('Task card', () => { | |||
| expect(queryByTestId('task-card')).toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| test('should show edit button when ALT key is long pressed', () => { | |||
| test('should show edit button when ALT key is long pressed', async () => { | |||
| server.use(...adminUserHandler); | |||
There was a problem hiding this comment.
Why are we using aminUserHandler here when we are not doing any testing related to it?
There was a problem hiding this comment.
Beacuse the code is written as {isUserAuthorized && showEditButton && <EditButton />} . So to get the isUserAuthorized values as true we need to use adminUserHandler. The long press of ALT key is just turning the boolean showEditButton from false to true.
…rsalan/website-status into refactor/useUserData_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Employ msw instead of jest.mock of useUserData hook in tests.
Description: In certain test files userUserData hook was being mocked to get some test value. The task is to employ msw in place of jest.mock.
Dev Tested:
Images/video of the change:
3 files needed change in total wrt to employing msw