Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidden not needed popups #577

Merged
merged 4 commits into from
Feb 20, 2024
Merged

hidden not needed popups #577

merged 4 commits into from
Feb 20, 2024

Conversation

skv93-coder
Copy link
Contributor

@skv93-coder skv93-coder commented Feb 18, 2024

Date: Feb 18 2024

Developer Name: @skv93-coder


Issue Ticket Number

#576

Description

It hides not needed popups for now.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Before
Screenshot from 2024-02-18 22-21-57
Screenshot from 2024-02-18 22-25-36

After
Screenshot from 2024-02-18 22-25-45

Screenshot from 2024-02-18 22-27-29

Test Coverage

Screenshot from 2024-02-17 10-39-23

Screenshot 1

Additional Notes

Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for staging-my ready!

Name Link
🔨 Latest commit 894ed4a
🔍 Latest deploy log https://app.netlify.com/sites/staging-my/deploys/65d19f7c962ad40008d5177e
😎 Deploy Preview https://deploy-preview-577--staging-my.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@skv93-coder skv93-coder changed the title Removed fetch test green button Removed not needed popups Feb 18, 2024
@skv93-coder skv93-coder marked this pull request as ready for review February 18, 2024 09:01
app/components/task/modal.hbs Show resolved Hide resolved
tests/integration/components/tasks-test.js Show resolved Hide resolved
app/components/tasks.hbs Show resolved Hide resolved
Copy link
Contributor

@Pavangbhat Pavangbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skv93-coder skv93-coder changed the title Removed not needed popups hidden not needed popups Feb 20, 2024
@iamitprakash iamitprakash merged commit f6fede8 into develop Feb 20, 2024
6 checks passed
@iamitprakash iamitprakash deleted the fix/remove-pop-ups branch February 20, 2024 11:37
@skv93-coder skv93-coder mentioned this pull request Feb 23, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants