Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to main sync #512

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Dev to main sync #512

merged 5 commits into from
Oct 30, 2023

Conversation

Ajeyakrishna-k
Copy link
Contributor

No description provided.

MayurLund and others added 3 commits October 14, 2023 23:04
* create button to allow multiple extensions

* add test for multiple extension request form

* fix style

* fix style

* fix style and refactor component

* refactor form and details and fix styles

* fix test cases

* final fix
…either approved or denied (#503)

* Feat : Added reviewed by log in extension status modal

* Test : Added test cases to verify review log
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for staging-my ready!

Name Link
🔨 Latest commit 83f4a06
🔍 Latest deploy log https://app.netlify.com/sites/staging-my/deploys/653f07d958973d000889801e
😎 Deploy Preview https://deploy-preview-512--staging-my.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 83f4a06
Status: ✅  Deploy successful!
Preview URL: https://179adffc.my-rds.pages.dev
Branch Preview URL: https://develop.my-rds.pages.dev

View logs

@joyguptaa
Copy link
Contributor

joyguptaa commented Oct 30, 2023

Developer Name: Joy Gupta

Purpose

Reviewed log should show the timestamp when the request was reviewed and not when it was created

PR Number(s): 512

Issue Ticket

Proposal Doc

https://docs.google.com/document/d/1sf-BAs7C6wmfjRVS-82X492hcb_7jAfIM-7pWtizuXE/edit

Frontend Changes

  • Yes
  • No

Is Under Feature Flag

  • Yes
  • No

Database changes:

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets):

  • Yes
  • No

Deployment notes:

NA

Tested in staging

  • Yes
  • No

List of PRs going in this Sync

QA Instructions, Screenshots, Recordings

Run yarn test:ember and there you can see test case running.
Screenshot 2023-10-29 at 11 45 23

Working Proof

The extension request was made 5 hours ago, but has been reviewed recently.
image
image

@iamitprakash iamitprakash merged commit 55898fe into main Oct 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants