revamped Stock listing page UI, closes #298 #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes color of stock cards and position of sell stocks button
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
closes #298 |
There was a problem hiding this comment.
Hey, I was testing out locally. But I cannot visit upon the page it gave me this error. Please handle it. User should barely get such errors on the screen.
Also please add the demo you use for the development. So I can test it out easily. And keep that data for now once we have API ready we will remove dummy data and use actual data.
Thank you.
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MehulKChaudhari Please review it and let me know of the required changes if any.
Thank you,
Akash