Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Run pre-commit #74

Merged
merged 4 commits into from
Dec 12, 2024
Merged

GitHub Actions: Run pre-commit #74

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d125d05
GitHub Actions: Run pre-commit
cclauss Dec 12, 2024
9357cd0
Update test_endpointer.py
cclauss Dec 12, 2024
494c4b8
pip install --editable .
cclauss Dec 12, 2024
ee5b632
tool.isort.known_first_party = ["soundswallower"]
cclauss Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ on:
- main
pull_request:
jobs:
pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.x
- uses: pre-commit/[email protected]
cclauss marked this conversation as resolved.
Show resolved Hide resolved
test:
runs-on: ubuntu-latest
steps:
Expand Down
1 change: 0 additions & 1 deletion py/test/test_endpointer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import unittest

import numpy as np

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem: when I run pre-commit run --all-files on my machine, or isort directly, this change gets undone.

The problem is that soundswallower is an internal module, and therefore there's a space between third party import (numpy) and internal imports, but pre-commit-action is not recognizing that here, it's lumping soundswallower with the third party imports.

Maybe a pip install -e . is required first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK... Let's try that. There is also the idea of isort known-first-party in the config but I like your idea more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose for just running isort, it's silly to install everything.
I was going to vote against known-first-party because I think isort ought to be able to figure it out, but for performance reasons I have changed my mind.

from soundswallower import Endpointer
cclauss marked this conversation as resolved.
Show resolved Hide resolved

DATADIR = os.path.join(os.path.dirname(__file__), "..", "..", "tests", "data")
Expand Down