-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos discovered by codespell #68
Conversation
Thanks for submitting this PR! Yes, fixing the typos is a good idea. |
Fixed at failing test? Modern OSes mandate a "managed" system Python where pip cannot install without a venv. |
Ah, I was wondering why this workflow did use the actions/setup-python, I guess it's a leftover from old CI files, because we use it everywhere else in our projects. I thought it might have been related to our old use of Hum, no, it's more complex: it's still failing, both your patch and my attempt in #69 |
BTW, if you want to exercise the CI in your fork without having to wait for my approval, you can create a PR from your branch to your own main and then you'll be able to troubleshoot on your side. |
And thanks for your help here, but don't feel obligated, we'll figure it out. |
pyproject.tomll: requires = [ "setuptools>=61.2" ] |
Right, the was my next line of inquiry, where to force the setuptools version, since the error messages complain about the version. |
I reverted all non-codespell changes. |
Urgh, CI ran on the old merge commit, not on the new one with my PR merged. Grrr. |
Approving anyway, we know this is fixed. |
Oh, thanks! I was wondering about that CI failure... |
PR Goal?
Fix typos with https://pypi.org/project/codespell
%
codespell --ignore-words-list=avance,delt --skip="dict.txt,*.pyx" --write-changes
Fixes?
Feedback sought?
Priority?
Tests added?
How to test?
Confidence?
Version change?