Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switchMap: pause the outer subscription when cancelling the inner subscription, then resuming #737

Merged
merged 8 commits into from
Oct 26, 2023
Merged

switchMap: pause the outer subscription when cancelling the inner subscription, then resuming #737

merged 8 commits into from
Oct 26, 2023

Conversation

hoc081098
Copy link
Collaborator

No description provided.

@hoc081098 hoc081098 added this to the 0.28.0 milestone Aug 30, 2023
@hoc081098
Copy link
Collaborator Author

hoc081098 commented Oct 19, 2023 •
edited
Loading

I am adding tests to verify the behavior

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #737 (b2f83aa) into master (18fd718) will increase coverage by 0.09%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head b2f83aa differs from pull request most recent head 845ae77. Consider uploading reports for the commit 845ae77 to get more accurate results

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   93.08%   93.18%   +0.09%     
==========================================
  Files          78       78              
  Lines        2431     2466      +35     
==========================================
+ Hits         2263     2298      +35     
  Misses        168      168

@hoc081098 hoc081098 changed the title pause subscription when cancelling inner subscription, then resume switchMap: pause the outer subscription when cancelling the inner subscription, then resuming Oct 26, 2023
@hoc081098 hoc081098 merged commit 49de304 into ReactiveX:master Oct 26, 2023
@hoc081098 hoc081098 deleted the switchmap_pause_resume branch October 26, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hoc081098 @codecov-commenter