Version 2.8 Changed the default for use_for_concrete

RamezIssac · Sep 15, 2020 · 735d10e · 735d10e
1 parent 8845a55
commit 735d10e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,6 +1,9 @@
 ----------
 CHANGELOG
 ----------
+ v 2.8 (15 September 2020)
+  - Changed default of use_for_concrete
+
  v 2.7 (16 August 2020)
   - Assert Django 3.1 Support.
   - Adds Django 3.1 to travis matrix.

diff --git a/README.rst b/README.rst
@@ -60,7 +60,7 @@ Tabular_permissions possible configurations and their default::
             'function':'tabular_permissions.helpers.dummy_permissions_exclude'
         },
         'auto_implement': True,
-        'use_for_concrete': True,
+        'use_for_concrete': False,
         'custom_permission_translation': 'tabular_permissions.helpers.custom_permissions_translator',
         'apps_customization_func': 'tabular_permissions.helpers.apps_customization_func',
         'custom_permissions_customization_func': 'tabular_permissions.helpers.custom_permissions_customization_func',
@@ -90,9 +90,11 @@ auto_implement
      See ``tabular_permissions.admin`` for information.
 
 use_for_concrete
-  There is an inconsistency with proxy models permissions (Django ticket `11154 <https://code.djangoproject.com/ticket/11154>`_).
+  Default: False (new in version 2.8)
 
-  So in case you have proxy models and you created their permissions by hand (via this `gist <https://gist.github.com/magopian/7543724>`_ maybe), then turn off this option in order to correctly assign your newly created permissions.
+  There was an inconsistency with proxy models permissions (Django ticket `11154 <https://code.djangoproject.com/ticket/11154>`_) which got fixed in Django 2.1
+  In case you're on an django <2.1 and you have proxy models and you created their permissions by hand (via this `gist <https://gist.github.com/magopian/7543724>`_ maybe), then turn off this option in order to correctly assign your newly created permissions.
+  For django > 2.1, leave it as is you should be good.
 
 custom_permission_translation
   A dotted path function to translate the custom permission.

diff --git a/tabular_permissions/__init__.py b/tabular_permissions/__init__.py
@@ -1 +1 @@
-__version__ = '2.7'
+__version__ = '2.8'
diff --git a/tabular_permissions/app_settings.py b/tabular_permissions/app_settings.py
@@ -10,7 +10,7 @@
         'function':'tabular_permissions.helpers.dummy_permissions_exclude'
     },
     'auto_implement': True,
-    'use_for_concrete': True,
+    'use_for_concrete': False,
     'custom_permission_translation': 'tabular_permissions.helpers.custom_permissions_translator',
     'apps_customization_func': 'tabular_permissions.helpers.apps_customization_func',
     'custom_permissions_customization_func': 'tabular_permissions.helpers.custom_permissions_customization_func',