GitHub Actions CI Port #16082
+194
−7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,171 @@ | ||
| name: Build RPCS3 | ||
|
|
||
| on: | ||
| push: | ||
| paths-ignore: | ||
| - '.cirrus.yml' | ||
| - '.azure-pipelines.yml' | ||
| - 'README.md' | ||
| pull_request: | ||
| paths-ignore: | ||
| - '.cirrus.yml' | ||
| - '.azure-pipelines.yml' | ||
| - 'README.md' | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.ref }}-${{ github.event_name }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| BUILD_REPOSITORY_NAME: ${{ github.repository }} | ||
| BUILD_SOURCEBRANCHNAME: ${{ github.ref_name }} | ||
| BUILD_ARTIFACTSTAGINGDIRECTORY: ${{ github.workspace }}/build | ||
|
|
||
| jobs: | ||
| Linux_Build: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - os: ubuntu-24.04 | ||
| docker_img: "rpcs3/rpcs3-ci-focal:1.9" | ||
| build_sh: "/rpcs3/.ci/build-linux.sh" | ||
| compiler: clang | ||
| - os: ubuntu-24.04 | ||
| docker_img: "rpcs3/rpcs3-ci-focal:1.9" | ||
| build_sh: "/rpcs3/.ci/build-linux.sh" | ||
| compiler: gcc | ||
| - os: ubuntu-24.04-arm | ||
| docker_img: "rpcs3/rpcs3-ci-focal-aarch64:1.0" | ||
| build_sh: "/rpcs3/.ci/build-linux-aarch64.sh" | ||
| compiler: clang | ||
| runs-on: ${{ matrix.os }} | ||
| env: | ||
| CCACHE_DIR: ${{ github.workspace }}/ccache | ||
| CI_HAS_ARTIFACTS: true | ||
| DEPLOY_APPIMAGE: true | ||
| APPDIR: "/rpcs3/build/appdir" | ||
| ARTDIR: "/root/artifacts" | ||
| RELEASE_MESSAGE: "/rpcs3/GitHubReleaseMessage.txt" | ||
| COMPILER: ${{ matrix.compiler }} | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@main | ||
| with: | ||
| submodules: recursive | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup Cache | ||
| uses: actions/cache@main | ||
| with: | ||
| path: ${{ env.CCACHE_DIR }} | ||
| key: ${{ runner.os }}-ccache-${{ matrix.compiler }} | ||
|
|
||
| - name: Docker setup and build | ||
| run: | | ||
| docker pull --quiet ${{ matrix.docker_img }} | ||
| docker run \ | ||
| -v $PWD:/rpcs3 \ | ||
| --env-file .ci/docker.env \ | ||
| -v ${{ env.CCACHE_DIR }}:/root/.ccache \ | ||
| -v ${{ github.workspace }}/artifacts:/root/artifacts \ | ||
| ${{ matrix.docker_img }} \ | ||
| ${{ matrix.build_sh }} | ||
|
|
||
| - name: Upload artifacts | ||
| #TODO: Upload artifact to release repository | ||
| #condition for release | ||
| #if: | | ||
| # github.event_name != 'pull_request' && | ||
| # github.repository == 'RPCS3/rpcs3' && | ||
| # github.ref == 'refs/heads/master' && | ||
| # matrix.compiler == 'clang' | ||
| uses: actions/upload-artifact@main | ||
| with: | ||
| name: RPCS3 for Linux (${{ runner.arch }}, ${{ matrix.compiler }}) | ||
| path: ${{ env.BUILD_ARTIFACTSTAGINGDIRECTORY }}/*.AppImage | ||
| compression-level: 0 | ||
|
|
||
| Windows_Build: | ||
| runs-on: windows-latest | ||
| env: | ||
| COMPILER: msvc | ||
| QT_VER_MAIN: '6' | ||
| QT_VER: '6.8.1' | ||
| QT_VER_MSVC: 'msvc2022' | ||
| QT_DATE: '202411221531' | ||
| VULKAN_VER: '1.3.268.0' | ||
| VULKAN_SDK_SHA: '8459ef49bd06b697115ddd3d97c9aec729e849cd775f5be70897718a9b3b9db5' | ||
| CACHE_DIR: ./cache | ||
| steps: | ||
|
|
||
| - name: Checkout repository | ||
| uses: actions/checkout@main | ||
| with: | ||
| submodules: recursive | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup env | ||
| run: | | ||
| echo "QTDIR=C:\Qt\${{ env.QT_VER }}\${{ env.QT_VER_MSVC }}_64" >> ${{ github.env }} | ||
| echo "VULKAN_SDK=C:\VulkanSDK\${{ env.VULKAN_VER }}" >> ${{ github.env }} | ||
|
|
||
| - name: Get Cache Keys | ||
| shell: bash | ||
| run: .ci/get_keys-windows.sh | ||
|
|
||
| - name: Setup Cache | ||
| uses: actions/cache@main | ||
| with: | ||
| path: ${{ env.CACHE_DIR }} | ||
| key: ${{ runner.os }}-${{ env.COMPILER }}-${{ env.QT_VER }}-${{ env.VULKAN_SDK_SHA }}-llvm.lock-glslang.lock | ||
|
There was a problem hiding this comment. I'm wondering if the llvm.lock and glslang.lock keys are working? In Azure providing the filename means it will hash the file for the key. However, in https://github.com/actions/cache#creating-a-cache-key I see that they use this function: |
||
| restore-keys: ${{ runner.os }}-${{ env.COMPILER }} | ||
|
|
||
| - name: Download and unpack dependencies | ||
| shell: bash | ||
| run: .ci/setup-windows.sh | ||
|
|
||
| - name: Export Variables | ||
|
There was a problem hiding this comment. This should should be in a script file. Also, is it possible to do this step in bash? There was a problem hiding this comment. It can be done in bash, as for making it a file, I'm afraid that There was a problem hiding this comment. Ahh that's unfortunate, if you could rewrite in bash that'd be great for consistency. |
||
| run: | | ||
| Get-Content ".ci/ci-vars.env" | ForEach-Object { | ||
| # Skip over lines containing comments. | ||
| if ($_ -notmatch '^\s*#') | ||
| { | ||
| $line = $_ -split '=' | ||
| $key = $line[0] | ||
| $val = $line[1] | ||
| echo "$key=$val" >> $env:GITHUB_ENV | ||
| } | ||
| } | ||
|
|
||
| - name: Add msbuild to PATH | ||
| uses: microsoft/setup-msbuild@main | ||
|
|
||
| - name: Compile RPCS3 | ||
| run: msbuild rpcs3.sln /p:Configuration=Release /p:Platform=x64 | ||
|
|
||
| - name: Pack up build artifacts | ||
| shell: bash | ||
| run: | | ||
| mkdir -p ${{ env.BUILD_ARTIFACTSTAGINGDIRECTORY }} | ||
| .ci/deploy-windows.sh | ||
|
|
||
| - name: Upload artifacts (7z) | ||
|
There was a problem hiding this comment. Same problems with the linux version of this step There was a problem hiding this comment. Should be sorted |
||
| #TODO: Upload artifact to release repository | ||
| #condition for release | ||
| #if: | | ||
| # github.event_name != 'pull_request' && | ||
| # github.repository == 'RPCS3/rpcs3' && | ||
| # github.ref == 'refs/heads/master' | ||
| uses: actions/upload-artifact@main | ||
| with: | ||
| name: RPCS3 for Windows (MSVC) | ||
| # 7z | ||
| # 7z.sha256 | ||
| path: | | ||
| ${{ env.BUILD_ARTIFACTSTAGINGDIRECTORY }}/${{ env.BUILD }} | ||
| ${{ env.BUILD_ARTIFACTSTAGINGDIRECTORY }}/${{ env.BUILD }}.sha256 | ||
| compression-level: 0 | ||
illusion0001 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if-no-files-found: error | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with
actions/upload-artifact@main, is this going to upload binaries to RPCS3/rpcs3-binaries-win/linux/linux-arm64/etc ? I don't see where we set any variables related to the upload repository, so I don't think this will work how we want it to.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also only run this step with the same restrictions we use in Azure:
condition: and(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.Repository.Name'], 'RPCS3/rpcs3'), eq(variables['Build.SourceBranch'], 'refs/heads/master'), eq(variables['COMPILER'], 'clang'))There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, there will have to be a separate step for it. Using appropriate tokens like azure to upload it