Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable user marker for vllm profiling #357

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Enable user marker for vllm profiling #357

merged 3 commits into from
Jan 16, 2025

Conversation

Lzy17
Copy link

@Lzy17 Lzy17 commented Jan 13, 2025 •
edited by github-actions bot
Loading

adding a user maker feature for vllm profiling
capture any code blocks in the trace
will only enable when profiling flag turns on

@Lzy17 Lzy17 requested review from dllehr-amd and gshtras January 13, 2025 17:18
gshtras
gshtras approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@gshtras gshtras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that this separation into distinct prefill and decode steps will be deprecated soon with the transition to vllm v1 engine

@Lzy17 Lzy17 merged commit 8bd76fb into main Jan 16, 2025
21 checks passed
@gshtras gshtras deleted the Lzy17/vllm_user_marker branch January 17, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshtras gshtras gshtras approved these changes

@dllehr-amd dllehr-amd Awaiting requested review from dllehr-amd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lzy17 @gshtras