Dockerfile improvements: multistage #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawong-amd
force-pushed
the
Dockerfile_multistage_refactor
branch
from
6a50d7d to
9061bd6
Compare
gshtras
reviewed
May 22, 2024
mawong-amd
force-pushed
the
Dockerfile_multistage_refactor
branch
from
9061bd6 to
206a720
Compare
mawong-amd
force-pushed
the
Dockerfile_multistage_refactor
branch
from
206a720 to
34174f8
Compare
|
Thanks @mawong-amd for this refactoring work. Can you also update build instruction documentation to reflect the change? |
|
Looks good to me. Thank you @mawong-amd |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the ROCm vLLM container to use a multi-stage build process, with a separate stage for each component (wheel or Debian package). This mirrors what is done in the CUDA Dockerfile in upstream, and greatly reduces the build time since all components can be built in parallel.
Python packages are now installed properly to
site-packagesusingpip install *.whlrather thanpython3 setup.py installorpython3 setup.py develop, both of which use egg-links.It also removes
/app/vllmas both a volume and directory to prevent accidental shadowing of thevllmmodule. If users want a vLLM development directory inside the container, they will have to mount one themselves.Pending regression tests.