Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip failures #39

Merged
merged 5 commits into from
Jul 29, 2024
Merged

skip failures #39

merged 5 commits into from
Jul 29, 2024

Conversation

Cemberk
Copy link
Collaborator

@Cemberk Cemberk commented Jul 25, 2024

skip failures for internal testing

@Cemberk Cemberk requested a review from amathews-amd July 25, 2024 21:40
def test_config(self):
self.config_tester.run_common_tests()


@skipIfRocm
def test_determinism(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did these tests come from ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

every function I added like this is coming from an inherited general test class which works on its own and for other models but is showing failure for that specific model in this case it is coming from ModelTesterMixin class from

def test_determinism(self):

@Cemberk Cemberk requested a review from amathews-amd July 29, 2024 16:33
Copy link
Collaborator

@amathews-amd amathews-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amathews-amd amathews-amd merged commit 5b2d4fe into develop Jul 29, 2024
4 checks passed
Cemberk added a commit that referenced this pull request Jul 29, 2024
* skip failures

* navi31 skip

* mi300 skips

* conversational test backwards compatability

* mi300 skips
Rohan138 pushed a commit that referenced this pull request Aug 5, 2024
* skip failures

* navi31 skip

* mi300 skips

* conversational test backwards compatability

* mi300 skips
Rohan138 pushed a commit that referenced this pull request Aug 5, 2024
* skip failures

* navi31 skip

* mi300 skips

* conversational test backwards compatability

* mi300 skips
@gargrahul gargrahul deleted the develop_skips branch August 6, 2024 16:51
Rohan138 pushed a commit that referenced this pull request Aug 6, 2024
* skip failures

* navi31 skip

* mi300 skips

* conversational test backwards compatability

* mi300 skips
github-actions bot referenced this pull request in Cemberk/transformers Aug 9, 2024
* skip failures

* navi31 skip

* mi300 skips

* conversational test backwards compatability

* mi300 skips
github-actions bot referenced this pull request in Cemberk/transformers Aug 9, 2024
* skip failures

* navi31 skip

* mi300 skips

* conversational test backwards compatability

* mi300 skips
github-actions bot referenced this pull request in Cemberk/transformers Aug 9, 2024
* skip failures

* navi31 skip

* mi300 skips

* conversational test backwards compatability

* mi300 skips
github-actions bot referenced this pull request in Cemberk/transformers Aug 10, 2024
* skip failures

* navi31 skip

* mi300 skips

* conversational test backwards compatability

* mi300 skips
Cemberk added a commit that referenced this pull request Sep 19, 2024
* skip failures

* navi31 skip

* mi300 skips

* conversational test backwards compatability

* mi300 skips
Cemberk added a commit that referenced this pull request Nov 20, 2024
* skip failures

* navi31 skip

* mi300 skips

* conversational test backwards compatability

* mi300 skips
Cemberk added a commit that referenced this pull request Nov 20, 2024
* skip failures

* navi31 skip

* mi300 skips

* conversational test backwards compatability

* mi300 skips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants