Fix hybrid type for ROCm

[Ruturaj4]

No description provided.

[github-actions]

Feature branch from main is ready. Create a new PR destined for upstream?

[charleshofer]

Looks like CI is failing due to this error: jax-ml#25664. Some deprecated scipy that upstream put in. There's a fix here. I suggest we just skip those tests until upstream gets the fix in: jax-ml#25675

[charleshofer]

Oh, I already fixed this upstream: https://github.com/jax-ml/jax/blame/main/jaxlib/tools/build_gpu_kernels_wheel.py#L148. The real question is how did we lose track of that change?

[charleshofer]

I fixed it downstream, too: #173

[charleshofer]

I don't understand how git is even generating that diff. In our rocm-main the file already points to the rocm directory, right? https://github.com/ROCm/jax/blame/rocm-main/jaxlib/tools/build_gpu_kernels_wheel.py#L148

[charleshofer]

It looks like the ci_hybrid_typo branch that you're using to make the PR split from upstream main like two months ago. That split happened before I pushed the fix to upstream, so it makes sense that when we try and open a PR that goes from ci_hybrid_typo-upstream to upstream main that there is no difference. What doesn't make sense to me is why when you open a PR from ci_hybrid_typo into rocm-main that GitHub shows a diff between the two branches. Anyways, unless I'm missing something, I think we can just close this PR.

@Ruturaj4 I'm not sure what the context is for you finding this bug, but if you use the latest rocm-main or the latest upstream main it's already fixed. Unless you're doing release work, it's generally not great to be using rocm-main or upstream main code from two months ago because you can end up re-debugging things like this.