Skip to content

Commit

Permalink
guard -it for docker with check
Browse files Browse the repository at this point in the history
  • Loading branch information
JehandadKhan committed Oct 2, 2024
1 parent 8a6a2c9 commit 6a0d1a6
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions build/rocm/ci_build
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def dist_wheels(

cmd.extend(mounts)

if os.isatty(sys.stdout.fileno()) and os.isatty(sys.stdin.fileno()):
if os.isatty(sys.stdout.fileno()):
cmd.append("-it")

# NOTE(mrodden): bazel times out without --init, probably blocking on a zombie PID
Expand Down Expand Up @@ -208,10 +208,12 @@ def test(image_name):
cmd = [
"docker",
"run",
"-it",
"--rm",
]

if os.isatty(sys.stdout.fileno()):
cmd.append("-it")

# NOTE(mrodden): we need jax source dir for the unit test code only,
# JAX and jaxlib are already installed from wheels
# docker run fails when mounting ./
Expand Down

0 comments on commit 6a0d1a6

Please sign in to comment.