Skip to content

Commit

Permalink
override image name
Browse files Browse the repository at this point in the history
  • Loading branch information
JehandadKhan committed Oct 2, 2024
1 parent f0125ad commit 4df858b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 11 deletions.
20 changes: 10 additions & 10 deletions .github/workflows/rocm-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v4
- name: Build Docker
env:
BUILD_TAG: rocm_jax_r6_1_3_py3_10_id${{ github.run_id }}
DOCKER_IMG_NAME: rocm_jax_r6_1_3_py3_10_id${{ github.run_id }}
# XLA_CLONE_DIR:
run: |
./build/rocm/ci_build.sh --rocm_version 6.1.3 \
Expand All @@ -23,12 +23,12 @@ jobs:
path: ${{ github.workspace }}/wheelhouse/*.whl


# - name: Try rocm-smi
# run: |
# docker run \
# --group-add video \
# $RENDER_DEVICES \
# --cap-add=SYS_PTRACE \
# --security-opt seccomp=unconfined \
# --shm-size=64G \
# rocm/rocm-terminal rocm-smi
- name: Detect GPUs
run: |
docker run \
--group-add video \
$RENDER_DEVICES \
--cap-add=SYS_PTRACE \
--security-opt seccomp=unconfined \
--shm-size=64G \
rocm/rocm-terminal rocm-smi
4 changes: 3 additions & 1 deletion build/rocm/ci_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,10 @@ WORKSPACE="${WORKSPACE:-$(upsearch WORKSPACE)}"
BUILD_TAG="${BUILD_TAG:-jax}"

# Determine the docker image name and BUILD_TAG.
DOCKER_IMG_NAME="${BUILD_TAG}.${CONTAINER_TYPE}"
DOCKER_IMG_NAME_DEFAULT="${BUILD_TAG}.${CONTAINER_TYPE}"

# Let the env override the image name
DOCKER_IMG_NAME="${DOCKER_IMG_NAME:-$DOCKER_IMG_NAME_DEFAULT}"
# Under Jenkins matrix build, the build tag may contain characters such as
# commas (,) and equal signs (=), which are not valid inside docker image names.
DOCKER_IMG_NAME=$(echo "${DOCKER_IMG_NAME}" | sed -e 's/=/_/g' -e 's/,/-/g')
Expand Down

0 comments on commit 4df858b

Please sign in to comment.