-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODING_CONVENTIONS.md: bump minimum Python version #21124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a minor complaint with the spelling correction being unmentioned. This is not enough to prevent my approval though.
Raising the minimum version is only a formality. Several features, such as f-strings are already used in the code base. In addition, the CI builds use a Docker images based on Ubuntu 22.04. Ubuntu 22.04 ships with Python 3.10.
56ca58f
to
ff20545
Compare
Minor formatting and spelling corrections in the Python coding convention section.
ff20545
to
4e7e28b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's been about time.
Contribution description
Raising the minimum version is only a formality. Several features, such as f-strings are already used in the code base.
In addition, the CI builds use a Docker image based on Ubuntu 22.04. Ubuntu 22.04 ships with Python 3.10.
While at it, I also improved the spelling a bit.
Testing procedure
Not applicable.
Issues/PRs references
None