Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODING_CONVENTIONS.md: bump minimum Python version #21124

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

basilfx
Copy link
Member

@basilfx basilfx commented Jan 9, 2025

Contribution description

Raising the minimum version is only a formality. Several features, such as f-strings are already used in the code base.

In addition, the CI builds use a Docker image based on Ubuntu 22.04. Ubuntu 22.04 ships with Python 3.10.

While at it, I also improved the spelling a bit.

Testing procedure

Not applicable.

Issues/PRs references

None

@basilfx basilfx added the Area: doc Area: Documentation label Jan 9, 2025
@basilfx basilfx requested a review from jia200x as a code owner January 9, 2025 21:59
@maribu maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 9, 2025
@riot-ci
Copy link

riot-ci commented Jan 9, 2025

Murdock results

✔️ PASSED

4e7e28b CODING_CONVENTIONS.md: improve spelling in Python section

Success Failures Total Runtime
1 0 1 01m:39s

Artifacts

@maribu maribu added the Process: needs >1 ACK Integration Process: This PR requires more than one ACK label Jan 9, 2025
@github-actions github-actions bot added the Process: missing approvals Integration Process: PR needs more ACKS (handled by action) label Jan 9, 2025
Copy link
Contributor

@Enoch247 Enoch247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor complaint with the spelling correction being unmentioned. This is not enough to prevent my approval though.

CODING_CONVENTIONS.md Show resolved Hide resolved
Raising the minimum version is only a formality. Several features,
such as f-strings are already used in the code base.

In addition, the CI builds use a Docker images based on Ubuntu 22.04.
Ubuntu 22.04 ships with Python 3.10.
@basilfx basilfx force-pushed the python-minimum-version branch from 56ca58f to ff20545 Compare January 10, 2025 06:34
@github-actions github-actions bot removed the Process: missing approvals Integration Process: PR needs more ACKS (handled by action) label Jan 10, 2025
Minor formatting and spelling corrections in the Python coding
convention section.
@basilfx basilfx force-pushed the python-minimum-version branch from ff20545 to 4e7e28b Compare January 10, 2025 06:35
Copy link
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's been about time.

@chrysn chrysn enabled auto-merge January 10, 2025 08:23
@chrysn chrysn added this pull request to the merge queue Jan 10, 2025
Merged via the queue into RIOT-OS:master with commit a8f3837 Jan 10, 2025
27 checks passed
@basilfx basilfx deleted the python-minimum-version branch January 10, 2025 08:31
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs >1 ACK Integration Process: This PR requires more than one ACK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants